cam6_4_056: Nitrogen deposition fluxes #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: bld/build-namelist modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/namelist_definition.xml modified: bld/namelist_files/use_cases/1850_cam_lt.xml modified: bld/namelist_files/use_cases/1850_cam_mt.xml modified: bld/namelist_files/use_cases/hist_cam_lt.xml modified: bld/namelist_files/use_cases/hist_cam_mt.xml modified: cime_config/buildnml modified: cime_config/config_component.xml modified: src/chemistry/mozart/chemistry.F90 modified: src/chemistry/mozart/mo_chm_diags.F90 modified: src/chemistry/pp_none/chemistry.F90 modified: src/control/camsrfexch.F90 modified: src/control/runtime_opts.F90 modified: src/cpl/nuopc/atm_import_export.F90 modified: src/cpl/nuopc/atm_stream_ndep.F90 modified: src/physics/cam/cam_diagnostics.F90 modified: src/utils/srf_field_check.F90
modified: bld/build-namelist modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/namelist_definition.xml modified: bld/namelist_files/use_cases/2010_cam6.xml modified: bld/namelist_files/use_cases/sd_cam6.xml modified: bld/namelist_files/use_cases/waccm_sc_1850_cam6.xml modified: src/chemistry/geoschem/chemistry.F90 modified: src/chemistry/pp_terminator/chemistry.F90 modified: src/control/camsrfexch.F90
modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_Leung_dust/user_nl_cam modified: doc/ChangeLog modified: src/utils/srf_field_check.F90
modified: src/physics/cam/cam_diagnostics.F90 modified: src/physics/cam/physpkg.F90
modified: src/physics/cam7/physpkg.F90
modified: src/cpl/nuopc/atm_import_export.F90 modified: src/cpl/nuopc/atm_stream_ndep.F90 modified: src/physics/cam/cam_diagnostics.F90
modified: src/cpl/nuopc/atm_import_export.F90
modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/1850_cam6.xml modified: bld/namelist_files/use_cases/hist_cam6.xml
brian-eaton
requested changes
Jan 6, 2025
…p_list modified: bld/build-namelist modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/namelist_definition.xml modified: bld/namelist_files/use_cases/1850_cam6.xml modified: bld/namelist_files/use_cases/1850_cam_lt.xml modified: bld/namelist_files/use_cases/1850_cam_mt.xml modified: bld/namelist_files/use_cases/2000_geoschem.xml modified: bld/namelist_files/use_cases/2000_trop_strat_vbs_cam6.xml modified: bld/namelist_files/use_cases/2010_cam6.xml modified: bld/namelist_files/use_cases/2010_geoschem.xml modified: bld/namelist_files/use_cases/2010_trop_strat_vbs_cam6.xml modified: bld/namelist_files/use_cases/hist_cam6.xml modified: bld/namelist_files/use_cases/hist_cam_lt.xml modified: bld/namelist_files/use_cases/hist_cam_mt.xml modified: bld/namelist_files/use_cases/hist_geoschem.xml modified: bld/namelist_files/use_cases/hist_geoschem_nudged.xml modified: bld/namelist_files/use_cases/hist_trop_strat_nudged_cam6.xml modified: bld/namelist_files/use_cases/hist_trop_strat_vbsext_cam6.xml modified: bld/namelist_files/use_cases/hist_trop_strat_vbsfire_cam6.xml modified: bld/namelist_files/use_cases/sd_cam6.xml modified: bld/namelist_files/use_cases/sd_trop_strat2_cam6.xml modified: bld/namelist_files/use_cases/sd_trop_strat_vbs_cam6.xml modified: bld/namelist_files/use_cases/sd_waccm_tsmlt_cam6.xml modified: bld/namelist_files/use_cases/waccm_ma_1850_cam6.xml modified: bld/namelist_files/use_cases/waccm_ma_hist_cam6.xml modified: bld/namelist_files/use_cases/waccm_sc_1850_cam6.xml modified: bld/namelist_files/use_cases/waccm_tsmlt_1850_cam6.xml modified: bld/namelist_files/use_cases/waccm_tsmlt_2000_cam6.xml modified: bld/namelist_files/use_cases/waccm_tsmlt_2010_cam6.xml modified: bld/namelist_files/use_cases/waccm_tsmlt_hist_cam6.xml
brian-eaton
reviewed
Jan 9, 2025
Collaborator
brian-eaton
left a comment
brian-eaton
left a comment
There was a problem hiding this comment.
The definition of sim_year in namelist_definition.xml needs to have 2010 and 1850-2015 added to the list of valid values.
I wasn't sure whether the sim_year attribute needed to be added to any of the use case files that don't currently set it. It depends on whether the use case is for a configuration that prognoses the ndep fluxes or not. I don't know how to figure that out without running the model.
modified: bld/namelist_files/namelist_definition.xml
cacraigucar
requested changes
Jan 10, 2025
Collaborator
cacraigucar
left a comment
cacraigucar
left a comment
There was a problem hiding this comment.
Minor comment requests
modified: bld/build-namelist modified: bld/namelist_files/use_cases/2010_geoschem.xml modified: bld/namelist_files/use_cases/hist_geoschem.xml modified: bld/namelist_files/use_cases/hist_geoschem_nudged.xml modified: doc/ChangeLog
brian-eaton
approved these changes
Jan 15, 2025
cacraigucar
approved these changes
Jan 15, 2025
cacraigucar
changed the title
modified: bld/namelist_files/namelist_defaults_cam.xml
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 13, 2025
Merge pull request ESCOMP#1216 from fvitt/nitro_dep_fluxes cam6_4_056: Nitrogen deposition fluxes ESCOMP commit: ea101b3
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 19, 2025
Merge pull request ESCOMP#1216 from fvitt/nitro_dep_fluxes cam6_4_056: Nitrogen deposition fluxes ESCOMP commit: ea101b3
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 23, 2025
Merge pull request ESCOMP#1216 from fvitt/nitro_dep_fluxes cam6_4_056: Nitrogen deposition fluxes ESCOMP commit: ea101b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1196